Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-7512: LearnerCreditAllocationTable course title #1025

Merged
merged 10 commits into from
Sep 1, 2023
Merged

Conversation

emrosarioa
Copy link
Contributor

@emrosarioa emrosarioa commented Aug 31, 2023

If a user of the admin portal does not have the learner portal enabled, the course title in the LearnerCreditAllocationTable "Enrollment details" column should be a string and not a link that would result in a 404.

Table when user does have learner portal enabled, with course title as links:
Screenshot 2023-08-31 at 4 49 54 PM

Table when user does not have learner portal enabled, with course titles as strings:

Screenshot 2023-08-31 at 4 54 58 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@emrosarioa emrosarioa changed the title ENT-7512: LearnerPortalAllocationTable course title ENT-7512: LearnerCreditAllocationTable course title Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ef1692d) 82.88% compared to head (537e5ca) 82.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         401      401           
  Lines        8727     8731    +4     
  Branches     1800     1803    +3     
=======================================
+ Hits         7233     7237    +4     
  Misses       1455     1455           
  Partials       39       39           
Files Changed Coverage Δ
...onents/learner-credit-management/BudgetCard-V2.jsx 100.00% <ø> (ø)
.../learner-credit-management/MultipleBudgetsPage.jsx 81.81% <ø> (ø)
...earner-credit-management/MultipleBudgetsPicker.jsx 50.00% <ø> (ø)
...credit-management/LearnerCreditAllocationTable.jsx 95.23% <100.00%> (+1.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emrosarioa emrosarioa merged commit 5a629a5 into master Sep 1, 2023
6 checks passed
@emrosarioa emrosarioa deleted the ea/ent-7512-2 branch September 1, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants